 |
RomRaiderOpen Source ECU Tools |
|
RomRaider
Documentation
Community
Developers
|
|
It is currently Thu Jan 08, 2009 11:28 pm
|
|
Page 1 of 1
|
[ 5 posts ] |
|
| Author |
Message |
|
merchgod
|
Post subject: FIXED: 0.2.7.4: real/byte conversion checker not working Posted: Wed Jun 14, 2006 9:18 pm |
|
 |
| Administrator |
 |
Joined: Wed Mar 29, 2006 10:38 pm Posts: 4224
|
|
Was editing some XML and deliberately put in a bogus expression in the real expression field. When opening a map, RomRaider did not alert me to that the real and byte calculations conflict. I know I've seen that error message before, so it was working at one point in time. Tried a different XML file (Braden's 5-23) and put in an obvious error, but still did not recognize it. Also made sure that the error checking was selected in settings. Also tried older versions 2.73, 2.72 with the same result.
|
|
| Top |
|
 |
|
merchgod
|
Post subject: Posted: Wed Jun 14, 2006 10:05 pm |
|
 |
| Administrator |
 |
Joined: Wed Mar 29, 2006 10:38 pm Posts: 4224
|
|
I think I figured out the problem. It looks like the expression checker takes the first z value on the ROM in a particular table and uses that value to check the expression and reverse expression's validity. The problem is, if the first value is zero then it nevers catches the problem, depending on the formula, because the end result is zero for both fields. For example, the I noticed this with the ignition correction table. I can put whatever I want in the real expression field and it doesn't pick it up.
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 6:35 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 12:33 pm Posts: 1770 Location: Palo, IA
|
|
I'll get this fixed in the next version.
_________________ jared.
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 9:51 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 12:33 pm Posts: 1770 Location: Palo, IA
|
|
Ok, the validation wasn't getting called on 3D tables (but it was in their axiis). Fixed. I also made some changes to the validation method for floats which could potentially cause some problems but I haven't run in to any. This will be in the next release, I'll do as much testing as I can before then.
Edit: Forgot to mention -- all it actually does is plug in an arbitrary value (it's 5) and calculate back and forth to make sure the result is 5. And now, with floats, it's actually making sure the result is within .001 of 5. There's where the potential problem could come in.
_________________ jared.
|
|
| Top |
|
 |
|
merchgod
|
Post subject: Posted: Mon Jul 03, 2006 11:56 pm |
|
 |
| Administrator |
 |
Joined: Wed Mar 29, 2006 10:38 pm Posts: 4224
|
|
Great. If the float thing gets to difficult, I would just leave it out as most of the values are straight values from the ECU, except where we want to convert psi or engine load and it is usually a simple equation.
|
|
| Top |
|
 |
|
Page 1 of 1
|
[ 5 posts ] |
|
Who is online |
Users browsing this forum: No registered users and 0 guests |
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot post attachments in this forum
|
|
|