RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Fri Jan 09, 2009 12:19 am

All times are UTC - 5 hours [ DST ]





Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 12 posts ] 
Author Message
 Post subject: CLOSED: strange slow down
PostPosted: Fri Jun 09, 2006 11:45 am 
Offline
Administrator
User avatar

Joined: Wed Mar 29, 2006 10:38 pm
Posts: 4225
I've been working on some XML and I've noticed that after you refresh the same ROM about 9 or 10 times, the loading of the tables starts to slow down. Every refresh after the 9th or 10th time gets slower and slower until it pretty much slows to a crawl. Closing out RomRaider at that point and reopening solves the problem until you refresh 9-10 times again.

Administrator Note: drees is working on this


Top
 Profile  
 
 Post subject:
PostPosted: Fri Jun 09, 2006 11:50 am 
Offline
Administrator
User avatar

Joined: Tue Jan 31, 2006 10:59 am
Posts: 365
Location: Montgomery, AL
cache getting full

_________________
Self-Proclaimed SuperNoob Moderator | Yes, I do have permission to use this image :D

[img]http://www.thumbsupracing.com/images/ultrasound.gif[/img]


Top
 Profile  
 
 Post subject: Re: strange slow down
PostPosted: Fri Jun 09, 2006 12:33 pm 
Offline
Experienced

Joined: Fri Mar 24, 2006 3:14 pm
Posts: 671
merchgod wrote:
I've been working on some XML and I've noticed that after you refresh the same ROM about 9 or 10 times, the loading of the tables starts to slow down. Every refresh after the 9th or 10th time gets slower and slower until it pretty much slows to a crawl. Closing out RomRaider at that point and reopening solves the problem until you refresh 9-10 times again.


This was previously reported, which I believed to be a "Memory Leak". I believe someone already fixed it however it hasn't been implemented into the new release yet.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Jun 13, 2006 2:15 pm 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Yep, there is a memory leak in the last release of RomRaider. I can post an updated RomRaider.jar file with the fix later when I get home if you want it.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Jun 14, 2006 6:56 pm 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Make a backup of your original RomRaider.jar and copy this one over. The slowdown after opening/closing lots of ROMs will be fixed. :D


You do not have the required permissions to view the files attached to this post.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Jun 14, 2006 7:06 pm 
Offline
Administrator
User avatar

Joined: Wed Mar 29, 2006 10:38 pm
Posts: 4225
Thanks!


Top
 Profile  
 
 Post subject:
PostPosted: Wed Jun 14, 2006 7:20 pm 
Offline
Experienced

Joined: Fri Mar 24, 2006 3:14 pm
Posts: 671
drees wrote:
Make a backup of your original RomRaider.jar and copy this one over. The slowdown after opening/closing lots of ROMs will be fixed. :D


This doesn't fix the "Refresh" memory problems. I just tried it and It bogged down after a few at 88mb, now at 90mb and its pretty slow. Closed the rom and its still at 90mb, opened new rom and its full CPU load bogging.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Jun 14, 2006 9:10 pm 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
ev8siv3 wrote:
This doesn't fix the "Refresh" memory problems. I just tried it and It bogged down after a few at 88mb, now at 90mb and its pretty slow. Closed the rom and its still at 90mb, opened new rom and its full CPU load bogging.

You're right, I just reproduced it on my system, I'll look at it again later tonight. Looks like evening opening and closing files enough times still produces a memory leak.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 15, 2006 5:34 am 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Give this one a shot. BTW, not sure why the other one didn't fix it. I think I uploaded the wrong .jar file.


You do not have the required permissions to view the files attached to this post.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 22, 2006 5:10 pm 
Offline
Administrator
User avatar

Joined: Wed Mar 29, 2006 10:38 pm
Posts: 4225
That seems to solve the problem. Also, it is faster in loading ROMs and bringing up tables. Great job!


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 22, 2006 5:20 pm 
Offline
Experienced

Joined: Fri Mar 24, 2006 3:14 pm
Posts: 671
Much better but I was still able to get it to bog down by opening a bunch of ROM's and refreshing. It seems that when the ROM is CLOSED it never clears the memory that was allocated for it so it continues to GROW as more Rom's are opened and used.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 22, 2006 7:28 pm 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Yep, it is better, but there are still some some subtle leaks in there which will show up if you do a LOT of ROM image close/opens. I've been working on it a bit and hope to have a fully fixed version in the next couple days.

I'll try the trick of loading up multiple ROMs and hitting refresh a bunch of times, that should really stress the cleanup routines.

The cause of the memory leak is references to the ROM data (of which there are many) which don't get properly released when a ROM image is closed which prevents the Java garbage collector to realize that the old objects are not in use and can be freed.

While I'm at it, I'm also cleaning up some of the code which should simplify some of the internal references as well.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 12 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl
phpBB SEO