RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Thu Jan 08, 2009 8:41 pm

All times are UTC - 5 hours [ DST ]





Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 4 posts ] 
Author Message
 Post subject: FIXED: 0.2.7.4b - Empty Exception when refreshing image
PostPosted: Wed May 10, 2006 3:41 am 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Right below the refreshImage function call in ECUEditorMenuBar around line 138 there is a "throw new Exception()" below it.

Seems to be useless so should be removed, maybe was left in there when debugging?


Top
 Profile  
 
 Post subject:
PostPosted: Wed May 10, 2006 11:26 pm 
Offline
Administrator
User avatar

Joined: Fri Jan 13, 2006 12:33 pm
Posts: 1770
Location: Palo, IA
Probably.. I'll take a look at it.

_________________
jared.


Top
 Profile E-mail  
 
 Post subject:
PostPosted: Thu May 11, 2006 2:50 am 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
qoncept wrote:
Probably.. I'll take a look at it.
I'll include it with the memory leak fix coming in a few minutes.


Top
 Profile  
 
 Post subject:
PostPosted: Thu May 11, 2006 3:39 am 
Offline
RomRaider Developer
User avatar

Joined: Thu Mar 23, 2006 5:21 am
Posts: 454
Location: San Diego, CA
Here's a diff of RomRaider\swing\ECUEditorMenuBar.java which removes the empty Exception (as well as fixing a couple of the JOptionPane.showMessageDialog static references I mentioned in the other thread).
Code:
@@ -130,15 +130,14 @@
             System.exit(0);
             
         } else if (e.getSource() == romProperties) {
-            new JOptionPane().showMessageDialog(parent, (Object)(new RomPropertyPanel(parent.getLastSelectedRom())),
+            JOptionPane.showMessageDialog(parent, (Object)(new RomPropertyPanel(parent.getLastSelectedRom())),
                     parent.getLastSelectedRom().getRomIDString() + " Properties", JOptionPane.INFORMATION_MESSAGE);
             
         } else if (e.getSource() == refreshImage) {
             try {
                 refreshImage();
-                throw new Exception();
             } catch (Exception ex) {           
-                new JOptionPane().showMessageDialog(parent, new DebugPanel(ex,
+                JOptionPane.showMessageDialog(parent, new DebugPanel(ex,
                         parent.getSettings().getSupportURL()), "Exception", JOptionPane.ERROR_MESSAGE);
             }
             


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 4 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl
phpBB SEO