RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Thu Jan 08, 2009 9:19 pm

All times are UTC - 5 hours [ DST ]





Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 10 posts ] 
Author Message
 Post subject: FIXED: 0.2.7.3b: 16 bit 3D tables do not save properly
PostPosted: Mon May 08, 2006 3:38 pm 
Offline
Administrator
User avatar

Joined: Fri Jan 13, 2006 12:33 pm
Posts: 1770
Location: Palo, IA
16-bit 3D tables are not saving properly. See http://www.romraider.com/forum/viewtopic.php?t=263 for more details.

Fix: Check save method in Table3D.

Notes:

Old:
Code:
        for (int x = 0; x < yAxis.getDataSize(); x++) {
            for (int y = 0; y < xAxis.getDataSize(); y++) {
                byte[] output = RomAttributeParser.parseIntegerValue(data[y][x].getBinValue(), endian, storageType);
                for (int z = 0; z < storageType; z++) {
                    binData[offset * storageType + storageAddress - ramOffset] = output[z];
                offset++;
                }
            }
        }



New:
Code:
        for (int x = 0; x < yAxis.getDataSize(); x++) {
            for (int y = 0; y < xAxis.getDataSize(); y++) {
                byte[] output = RomAttributeParser.parseIntegerValue(data[y][x].getBinValue(), endian, storageType);
                for (int z = 0; z < storageType; z++) {
                    binData[offset * storageType + z + storageAddress - ramOffset] = output[z];
                }
                offset++;
            }
        }

_________________
jared.


Last edited by qoncept on Tue May 09, 2006 1:24 pm, edited 2 times in total.

Top
 Profile E-mail  
 
 Post subject:
PostPosted: Mon May 08, 2006 11:13 pm 
Offline
Newbie

Joined: Tue Apr 04, 2006 2:23 pm
Posts: 49
You wrote: Fix: Check save method in Table3D.

Is this the answer to the problem? I can't figure out how to.


Top
 Profile  
 
 Post subject:
PostPosted: Tue May 09, 2006 7:54 am 
Offline
Administrator
User avatar

Joined: Fri Jan 13, 2006 12:33 pm
Posts: 1770
Location: Palo, IA
In the source code.. I need to do it. ;) I think I'm going to see if I can fix it and release a new version with it today but I'm not sure if I'll get the time to. Cross your fingers.

_________________
jared.


Top
 Profile E-mail  
 
 Post subject:
PostPosted: Tue May 09, 2006 9:10 am 
Offline
Newbie
User avatar

Joined: Thu Apr 27, 2006 1:47 am
Posts: 50
*ahem*CEL checkbox disable as well*ahem* :P


Top
 Profile  
 
 Post subject:
PostPosted: Tue May 09, 2006 9:15 am 
Offline
Administrator
User avatar

Joined: Fri Jan 13, 2006 12:33 pm
Posts: 1770
Location: Palo, IA
They'll go in the next version ;) All I need to do is find a logic error to fix this bug so it should only take about 10 minutes (and I just started working on it now). Plus, this is a relatively major bug that could cause big problems if someone screwed up their ROM with it, so I want to get it fixed ASAP.

_________________
jared.


Top
 Profile E-mail  
 
 Post subject:
PostPosted: Tue May 09, 2006 11:45 am 
Offline
Newbie

Joined: Tue Apr 04, 2006 2:23 pm
Posts: 49
Great thanks :wink:


Top
 Profile  
 
 Post subject:
PostPosted: Tue May 09, 2006 11:52 am 
Offline
Newbie

Joined: Tue Apr 04, 2006 2:23 pm
Posts: 49
Great thanks :wink:


Top
 Profile  
 
 Post subject:
PostPosted: Fri May 19, 2006 4:38 pm 
Offline
Experienced

Joined: Fri Mar 24, 2006 3:14 pm
Posts: 671
I think this may still be a problem.

I am trying to modify values on the BOOST - Target PSI (MT) map for A4TF800F/E and 3 values simply WILL NOT save.

4800rpm, the values for 12% 24% 36% throttle all default back to original values when I save any new value to them. I haven't tested on other ROM's yet but this one kinda popped out.


Top
 Profile  
 
 Post subject:
PostPosted: Fri May 19, 2006 4:52 pm 
Offline
Administrator
User avatar

Joined: Fri Jan 13, 2006 12:33 pm
Posts: 1770
Location: Palo, IA
Huh.. weird. Can you upload the def you're using and let me know what version the ROM is?

_________________
jared.


Top
 Profile E-mail  
 
 Post subject:
PostPosted: Fri May 19, 2006 4:59 pm 
Offline
Experienced

Joined: Fri Mar 24, 2006 3:14 pm
Posts: 671
qoncept wrote:
Huh.. weird. Can you upload the def you're using and let me know what version the ROM is?


Whats strange is a tried it on a bone stock 800E and it saved fine. However on my modified one it is not. Attached are both the XML and the custom ROM I made. Try changing those values and saving it, they won't take for me.


You do not have the required permissions to view the files attached to this post.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 10 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl
phpBB SEO